Use detachEvent when removeEventListener isn't available #18110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow pr 18028 fix for update removeEventListener to detachEvent
|
build js |
peterhashair
changed the title
|
@peterhashair is this one ready to review? Looks good to merge from my side Was almost thinking we might want to put this in a 4.5.1 release but it should not be needed as it would be very rarely executed and also only affects very few very old browsers. |
|
@tsteur should be good to merge |
justinvelluppillai
approved these changes
Oct 8, 2021
justinvelluppillai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow Ref:#18028. Update removeEventListener to detachEvent.
@paladox Point out this typo or error.
Review