Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO ranking Plugin tests update #18109

Merged
merged 4 commits into from Oct 8, 2021
Merged

SEO ranking Plugin tests update #18109

merged 4 commits into from Oct 8, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Oct 7, 2021

Description:

Fixes: #17919

SEO test is failed randomly, normally a rerun will get it passed.

Call a recluse to rerun the SEO test 3 times inside of the tests to reduce the chance of failing.

Instead of test Microsoft, test matomo.org.

Review

Peter Zhang added 2 commits October 8, 2021 09:47
when seo test failed retry 3 times
add some returns and tidy up the functin.
@peterhashair peterhashair changed the title change seo test update SEO test Oct 7, 2021
@peterhashair peterhashair changed the title update SEO test SEO ranking Plugin tests update Oct 7, 2021
@peterhashair
Copy link
Contributor Author

Not sure this will fix it, probably needs more people to run it in the Travis, I simulate run that test function 20 times in a short period, none of those simulations failed.

@peterhashair peterhashair added this to the 4.6.0 milestone Oct 7, 2021
@peterhashair peterhashair marked this pull request as ready for review October 7, 2021 22:43
@tsteur
Copy link
Member

tsteur commented Oct 7, 2021

@peterhashair is this one ready for review? We could otherwise simply merge and see if it still fails randomly over time. If we still see it failing then we'd try another approach.

@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 8, 2021
@peterhashair
Copy link
Contributor Author

@tsteur yeah, I think it still will fail over time, not a perfect solution, but should reduce the fail times.

updated seo test condition
update error message to it was
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once tests have run.

@tsteur tsteur merged commit 52caa6e into 4.x-dev Oct 8, 2021
@tsteur tsteur deleted the m-17919-seo-test branch October 8, 2021 01:02
@peterhashair
Copy link
Contributor Author

@tsteur maybe that doesn't work. see here https://app.travis-ci.com/github/matomo-org/matomo/jobs/542068646

@tsteur
Copy link
Member

tsteur commented Oct 8, 2021

👍 I'll reopen the issue again so we can try a different approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEO Ranking plugin not working - problem with ping? - Fix the random test failures
3 participants