New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO ranking Plugin tests update #18109
Conversation
when seo test failed retry 3 times
add some returns and tidy up the functin.
Not sure this will fix it, probably needs more people to run it in the Travis, I simulate run that test function 20 times in a short period, none of those simulations failed. |
@peterhashair is this one ready for review? We could otherwise simply merge and see if it still fails randomly over time. If we still see it failing then we'd try another approach. |
@tsteur yeah, I think it still will fail over time, not a perfect solution, but should reduce the fail times. |
updated seo test condition
update error message to it was
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge once tests have run.
@tsteur maybe that doesn't work. see here https://app.travis-ci.com/github/matomo-org/matomo/jobs/542068646 |
👍 I'll reopen the issue again so we can try a different approach |
Description:
Fixes: #17919
SEO test is failed randomly, normally a rerun will get it passed.
Call a recluse to rerun the SEO test 3 times inside of the tests to reduce the chance of failing.
Instead of test Microsoft, test matomo.org.
Review