Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more granular access control for segment creation #18107

Closed
tomper00 opened this issue Oct 7, 2021 · 1 comment · Fixed by #18113
Closed

Add more granular access control for segment creation #18107

tomper00 opened this issue Oct 7, 2021 · 1 comment · Fixed by #18113
Assignees
@peterhashair
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.6.0

Comments

@tomper00
Copy link

tomper00 commented Oct 7, 2021

In config.php.ini there is a variable called:
adding_segment_requires_access
; Possible values are "view", "admin", "superuser"

It would be great if we could add write to the list of valid configurations, since creating segments on larges sites can be quite sensitive from a performance perspective.
@tomper00 tomper00 added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Oct 7, 2021
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 7, 2021
@tsteur tsteur added this to the 4.8.0 milestone Oct 7, 2021
@tsteur
Copy link
Member

tsteur commented Oct 7, 2021

Makes sense 👍 thanks for reporting this @tomper00

@peterhashair peterhashair self-assigned this Oct 8, 2021
@peterhashair peterhashair mentioned this issue Oct 8, 2021
Merged
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.8.0, 4.6.0 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

add write to adding_segment_requires_access matomo-org/matomo
4 participants
@tsteur @tomper00 @justinvelluppillai @peterhashair