Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] migrate piwik service and test #18106

Merged
merged 8 commits into from Oct 11, 2021
Merged

[Vue] migrate piwik service and test #18106

merged 8 commits into from Oct 11, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Oct 7, 2021

Description:

Based off of #18104

Migrate piwik service + test.

Note: there are some changes regarding how globals are accessed. These are mostly for tests, since the tests are invoked within node.js (so globals are set via the global object), so we have to access them from window rather than just using them.

image

Review

@diosmosis diosmosis added this to the 4.6.0 milestone Oct 7, 2021
@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 7, 2021
@tsteur
Copy link
Member

tsteur commented Oct 8, 2021

fyi @diosmosis there are few merge conflicts

@diosmosis
Copy link
Member Author

@tsteur fixed

@tsteur tsteur merged commit cb71753 into 4.x-dev Oct 11, 2021
@tsteur tsteur deleted the vue-piwik branch October 11, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants