Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduled tasks should not launch archiving when browser archiving is disabled #18101

Merged
merged 5 commits into from Oct 8, 2021
Merged

scheduled tasks should not launch archiving when browser archiving is disabled #18101

merged 5 commits into from Oct 8, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Oct 6, 2021 •
edited

Description:

Fixes #17976

This PR remove $_GET['trigger'] == 'archivephp' from CronArchive.

Review

differentiate the CLI and the browser request on Archives
f6b2e93 
differentiate the CLI and the browser request on Archives
@peterhashair peterhashair marked this pull request as ready for review October 6, 2021 05:24
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 6, 2021
@peterhashair peterhashair added this to the 4.6.0 milestone Oct 6, 2021
@peterhashair peterhashair removed the Needs Review PRs that need a code review label Oct 6, 2021
remove archivephp
bcfcb03 
remove $_GET['trigger'] = 'archivephp' in purgeOUtdateArchives
@peterhashair peterhashair changed the title differentiate the CLI and the browser request on Archives scheduled tasks should not launch archiving when browser archiving is disabled Oct 6, 2021
@peterhashair peterhashair added the Needs Review PRs that need a code review label Oct 6, 2021
set a replacement for the archivephp
11ae8fe 
move archivephp to Rule static variables.
update teardown in test
cb93120 
update teardown in test , enable purge in cronArchive
@tsteur tsteur merged commit b9ba1e5 into 4.x-dev Oct 8, 2021
@tsteur tsteur deleted the m-17976-archiving-exclude-schedule-task branch October 8, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Scheduled tasks should not launch archiving
2 participants
@peterhashair @tsteur