Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UI tests work again as they fail regarding SSL certs #18098

Closed
tsteur opened this issue Oct 5, 2021 · 1 comment · Fixed by #18111
Closed

Make UI tests work again as they fail regarding SSL certs #18098

tsteur opened this issue Oct 5, 2021 · 1 comment · Fixed by #18111
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.6.0

Comments

@tsteur
Copy link
Member

tsteur commented Oct 5, 2021 •
edited

From @Findus23 changing the travis yml to https://github.com/matomo-org/matomo/compare/ui-tests-bionic seems to fix the UI tests by getting it to use bionic. Note that this change fails other tests see https://app.travis-ci.com/github/matomo-org/matomo/jobs/540837360#L414 meaning we likely need to also adjust the travis template in https://github.com/matomo-org/travis-scripts/blob/master/generator/TravisYmlView.php#L258 or make it work some other way.

Instead of removing the dist entry we would change it to bionic.

We probably also need to create some documentation around this part of travis in https://developer.matomo.org/guides/tests-travis-extended if that's not done yet.

I'm not 100% sure about best way to solve this. However, I think for the UI test group we can simply change the dist to bionic without needing any change in travis-scripts actually.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 5, 2021
@tsteur tsteur added this to the 4.6.0 milestone Oct 5, 2021
@tsteur tsteur mentioned this issue Oct 7, 2021
Closed
3 tasks
@tsteur tsteur self-assigned this Oct 8, 2021
@tsteur tsteur mentioned this issue Oct 8, 2021
Merged
11 tasks
@tsteur tsteur removed their assignment Oct 8, 2021
@tsteur
Copy link
Member Author

tsteur commented Oct 8, 2021 •
edited

Created #18111 thought to fix this quick but turns out the UI tests still fail. Unassigning myself as I won't have the time to complete it.

Maybe someone could continue in #18111?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Fix UI tests as it fails to fetch data from marketplace matomo-org/matomo
1 participant
@tsteur