New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] introduce frontend unit testing for vue & migrate periods.spec.js #18092
Conversation
…a plugin is not compatible w/ vue 3 and no one is working on making it compatible)
fyi @diosmosis there's a merge conflict and the tests fail in https://app.travis-ci.com/github/matomo-org/matomo/jobs/540966028#L1375-L1381 The tests itself succeed but some package file seems to not exist? |
@tsteur seeing there is now a ReleaseCheckListTest failure due to matomo.zip size. The package-lock.json file is the biggest now, but I think we don't need to include this in the release. What do you think? |
@diosmosis indeed we can ignore that one and not include it in the release. Are the tests otherwise passing? |
@tsteur there are some ui test failures, but they seem unrelated. They're not failing on 4.x-dev though, so re-running the build to see if they're random. Is it ok to merge if they pass? |
@tsteur looks like some were random. The bulk of the other failures have this error:
I'll see if I can fix the build in this PR. |
@diosmosis I assume that's still because of the UI tests using Xenial |
@tsteur build is passing. I've also created a matomo-package pr. |
@diosmosis looks good for me to merge. I tested and seemed to work and also had a look through the code. It says though that #18091 needs to be merged first? Is this still the case or we simply merge this PR and close #18091? |
@tsteur this pr is built on that one, so this can be merged and the other ignored if desired. I only split them apart so they'd be easier to review (if needed). |
@tsteur can you take a look at ^? |
That looks all good to me @diosmosis 👍 |
@tsteur ok, will merge soon |
Description:
This PR is based off #18091. That must be merged first. Or just merge this one and close the other I guess.
Review