@diosmosis opened this Pull Request on October 2nd 2021 Member

Description:

This PR is based off #18091. That must be merged first. Or just merge this one and close the other I guess.

  • Introducing jest + jsdom to replace anguarjs unit tests. There was a mocha/karma integration for Vue, but it doesn't work with Vue 3 and no one seems to be working on that. Currently I'm not using chai, though it could be if desired.
  • Run vue tests in travis-ci AngularJS job.
  • Migrate the periods angular service tests to TypeScript + Jest.

image

Review

@tsteur commented on October 3rd 2021 Member

fyi @diosmosis there's a merge conflict and the tests fail in https://app.travis-ci.com/github/matomo-org/matomo/jobs/540966028#L1375-L1381 The tests itself succeed but some package file seems to not exist?

@diosmosis commented on October 4th 2021 Member

@tsteur / @sgiehl the typescript compiler wasn't behaving the same on travis-ci vs. locally. I found a configuration that works, so it's passing now, but I'm not sure why it behaves differently locally.

@diosmosis commented on October 4th 2021 Member

@tsteur seeing there is now a ReleaseCheckListTest failure due to matomo.zip size. The package-lock.json file is the biggest now, but I think we don't need to include this in the release. What do you think?

@tsteur commented on October 4th 2021 Member

@diosmosis indeed we can ignore that one and not include it in the release. Are the tests otherwise passing?

@diosmosis commented on October 4th 2021 Member

@tsteur there are some ui test failures, but they seem unrelated. They're not failing on 4.x-dev though, so re-running the build to see if they're random. Is it ok to merge if they pass?

@diosmosis commented on October 4th 2021 Member

@tsteur looks like some were random. The bulk of the other failures have this error:

         <div class='alert alert-danger'><strong>Error:</strong> curl_exec: SSL certificate problem: certificate has expired. Hostname requested was: plugins.piwik.org</div>

I'll see if I can fix the build in this PR.

@Findus23 commented on October 4th 2021 Member

@diosmosis I assume that's still because of the UI tests using Xenial

@diosmosis commented on October 5th 2021 Member

@tsteur build is passing. I've also created a matomo-package pr.

@tsteur commented on October 5th 2021 Member

@diosmosis looks good for me to merge. I tested and seemed to work and also had a look through the code. It says though that https://github.com/matomo-org/matomo/pull/18091 needs to be merged first? Is this still the case or we simply merge this PR and close #18091?

@diosmosis commented on October 5th 2021 Member

@tsteur this pr is built on that one, so this can be merged and the other ignored if desired. I only split them apart so they'd be easier to review (if needed).

@diosmosis commented on October 5th 2021 Member

@tsteur can you take a look at ^?

@tsteur commented on October 5th 2021 Member

That looks all good to me @diosmosis 👍

@diosmosis commented on October 5th 2021 Member

@tsteur ok, will merge soon

This Pull Request was closed on October 5th 2021
Powered by GitHub Issue Mirror