This PR is based off #18091. That must be merged first. Or just merge this one and close the other I guess.
fyi @diosmosis there's a merge conflict and the tests fail in https://app.travis-ci.com/github/matomo-org/matomo/jobs/540966028#L1375-L1381 The tests itself succeed but some package file seems to not exist?
@tsteur seeing there is now a ReleaseCheckListTest failure due to matomo.zip size. The package-lock.json file is the biggest now, but I think we don't need to include this in the release. What do you think?
@diosmosis indeed we can ignore that one and not include it in the release. Are the tests otherwise passing?
@tsteur there are some ui test failures, but they seem unrelated. They're not failing on 4.x-dev though, so re-running the build to see if they're random. Is it ok to merge if they pass?
@tsteur looks like some were random. The bulk of the other failures have this error:
<div class='alert alert-danger'><strong>Error:</strong> curl_exec: SSL certificate problem: certificate has expired. Hostname requested was: plugins.piwik.org</div>
I'll see if I can fix the build in this PR.
@diosmosis I assume that's still because of the UI tests using Xenial
@tsteur build is passing. I've also created a matomo-package pr.
@tsteur this pr is built on that one, so this can be merged and the other ignored if desired. I only split them apart so they'd be easier to review (if needed).