@diosmosis opened this Pull Request on October 2nd 2021 Member

Description:

NOTE: missing file headers will be added in https://github.com/matomo-org/matomo/pull/18092

Changes:

  • Migrate the periods service into several new classes.
  • Switch the angularjs karma tests to use the ChromeHeadless runner, since phantomjs will not support running Vue code.
  • Added some global type definitions for frontend globals.
  • Added jquery/jquery-ui type definitions.
  • Before running vue build commands, delete the ./node_modules/.cache folder to prevent some seemingly random issues when compiling.

image

image

Review

@diosmosis commented on October 2nd 2021 Member

If there are any comments on code style, feel free to bring them up. At the moment I'm just following the airbnb eslint rules.

This Pull Request was closed on October 5th 2021
Powered by GitHub Issue Mirror