Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Migrate periods service to typescript and some extra changes #18091

Closed
wants to merge 6 commits into from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Oct 2, 2021

Description:

NOTE: missing file headers will be added in #18092

Changes:

  • Migrate the periods service into several new classes.
  • Switch the angularjs karma tests to use the ChromeHeadless runner, since phantomjs will not support running Vue code.
  • Added some global type definitions for frontend globals.
  • Added jquery/jquery-ui type definitions.
  • Before running vue build commands, delete the ./node_modules/.cache folder to prevent some seemingly random issues when compiling.

image

image

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 2, 2021
@diosmosis diosmosis added this to the 4.6.0 milestone Oct 2, 2021
@diosmosis
Copy link
Member Author

If there are any comments on code style, feel free to bring them up. At the moment I'm just following the airbnb eslint rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant