Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace db error message #18085

Merged
merged 1 commit into from Oct 1, 2021
Merged

replace db error message #18085

merged 1 commit into from Oct 1, 2021

Conversation

peterhashair
Copy link
Contributor

Description:

Make error messages not leak potentially sensitive information when connection failed

Review

replace db error message
32b6b85 
Make error messages not leak potentially sensitive information when connection failed
@peterhashair peterhashair added this to the 4.6.0 milestone Sep 30, 2021
@peterhashair peterhashair linked an issue Sep 30, 2021 that may be closed by this pull request
Make error messages not leak potentially sensitive information when tracker db connection fails #18079
Closed
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 30, 2021
@peterhashair peterhashair marked this pull request as ready for review October 1, 2021 03:29
@peterhashair peterhashair added the Needs Review PRs that need a code review label Oct 1, 2021
@sgiehl sgiehl merged commit 0d4f122 into 4.x-dev Oct 1, 2021
@sgiehl sgiehl deleted the m-18079-tracker-db-error-msg branch October 1, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Make error messages not leak potentially sensitive information when tracker db connection fails
2 participants
@peterhashair @sgiehl