New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix randomly failing UI tests #18082
Comments
This is another one I've seen that doesn't load the css https://builds-artifacts.matomo.org/matomo-org/matomo/m-6032-export-transitions/49534/UIIntegrationTest_admin_themes.png |
There is one that always failed on my pr.
Just a thought, is that possible we only run tests on the parts we changed. like a subModule or Composer package :) |
There is a general problem with automatically retrying UI tests. We have a lot tests that rely on the state of the previous test or that perform actions that can't be done again (like adding or removing stuff). So we could only rerun the whole test suite if one test failed, which then could cause timeouts if a long running test suite is rerun automatically. Regarding the not loaded CSS/JS. I already added a lot code that automatically tries to load the CSS/JS again if the request fails, but there still seem to be some circumstances where all requests serve an empty response, so I guess the generated and cached CSS/JS is kind of empty and re-requesting it doesn't help. @peterhashair I'll try to fix that failing Overlay UI test. Not yet sure why it fails, as it's working correctly locally. |
The overlay UI test should be fixed with #18084 |
Note the premium feature UI test will be fixed by #18098 |
Another randomly failing one: https://builds-artifacts.matomo.org/matomo-org/matomo/m-3513-stick-table-top/50217/Dashboard_change_layout.png |
It seems this starts to fail randomly. eg: https://app.travis-ci.com/github/matomo-org/matomo/jobs/547051754 |
Found this one today, apparently random
|
I guess this is old one.
|
There is a new one.
|
Not sure this is random. After ce27828 start to fail
|
@peterhashair Same is happening with me on #18732 |
@AltamashShaikh it seems like started to fail quite often, will have a deep look now. |
It seems like related to travis. github action works https://github.com/matomo-org/matomo/actions/runs/1793294031
|
Seems this fail randomly very often rencetly
|
I'm actually tempted to close this issue simply. We should always try to keep our builds green. If someone sees that a test fails randomly quite often they can simply try to improve that behavior and create a PR or create an issue instead that mentions that specific test only. Gathering more and more tests that might have failed randomly in one issue makes it extremely hard to even work on it. Some of tests here were meanwhile fixed, others might start to fail while someone might work on that issue and new comments with failing tests might be added. |
Cool I will close this now and we can create individual issues for any tests that fail in future. |
These ones fail randomly quite often AFAIK
Could we maybe retry them when they fail? or try to fix them in a different way?
The text was updated successfully, but these errors were encountered: