Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker #18078

Merged
merged 1 commit into from Sep 29, 2021
Merged

When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker #18078

merged 1 commit into from Sep 29, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Sep 29, 2021 •
edited

Description:

This issue comes from Matomo version <4.0.0, hide sparkline when is zero.

Review

remove avg time
9eae870 
remove avg time if is zero
@peterhashair peterhashair added this to the 4.6.0 milestone Sep 29, 2021
@peterhashair peterhashair linked an issue Sep 29, 2021 that may be closed by this pull request
When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker #17010
Closed
@peterhashair peterhashair changed the title remove avg time When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker Sep 29, 2021
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 29, 2021
@peterhashair peterhashair marked this pull request as ready for review September 29, 2021 08:19
sgiehl
sgiehl approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected 👍

@sgiehl sgiehl merged commit 83388c2 into 4.x-dev Sep 29, 2021
@sgiehl sgiehl deleted the m-17010-hide-sparklink branch September 29, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

When "average generation time" is zero, hide the sparkline and "Avg generation time" graphs metric from picker
2 participants
@peterhashair @sgiehl