Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Users' or 'UserId' tab no data: explain how to populate Users report data #18077

Merged
merged 5 commits into from Oct 5, 2021
Merged

'Users' or 'UserId' tab no data: explain how to populate Users report data #18077

merged 5 commits into from Oct 5, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Sep 29, 2021 •
edited

Description:

Fixes: #11175

update the userId under visitors. when there is no data for this report, explain how to populate report data.

Review

update the userId report guide
8230342 
update the userId report guide when there is no data
@peterhashair peterhashair linked an issue Sep 29, 2021 that may be closed by this pull request
Improve help text on 'Users' report when no data #11175
Closed
@peterhashair peterhashair changed the title update the userId report guide 'Users' or 'UserId' tab no data: explain how to populate Users report data Sep 29, 2021
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Sep 29, 2021
@peterhashair peterhashair added this to the 4.6.0 milestone Sep 29, 2021
@peterhashair peterhashair marked this pull request as ready for review September 29, 2021 04:37
@peterhashair peterhashair added the Needs Review PRs that need a code review label Oct 5, 2021
@peterhashair
Copy link
Contributor Author

expected a UI tests, but doesn't have a UI test for that one.

tsteur
tsteur requested changes Oct 5, 2021
View reviewed changes
plugins/UserId/Reports/GetUsers.php Outdated Show resolved Hide resolved
plugins/UserId/lang/en.json Outdated Show resolved Hide resolved
Peter Zhang and others added 2 commits October 5, 2021 16:14
@tsteur
Copy link
Member

tsteur commented Oct 5, 2021

👍 fyi @peterhashair also added it to the subcategory help so users should have heaps of links about this now :)
image

it was also already shown in the help
image

@tsteur
Copy link
Member

tsteur commented Oct 5, 2021

should be good to merge @peterhashair (maybe wait for tests to finish just in case)

@peterhashair peterhashair merged commit 8998ae3 into 4.x-dev Oct 5, 2021
@peterhashair peterhashair deleted the m-11175-userid-no-data branch October 5, 2021 09:08
@peterhashair peterhashair mentioned this pull request Oct 5, 2021
Merged
11 tasks
@Findus23 Findus23 mentioned this pull request Oct 9, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Improve help text on 'Users' report when no data
2 participants
@peterhashair @tsteur