@diosmosis opened this Pull Request on September 29th 2021 Member

Description:

To catch when someone pushes a development build of a UMD module (as I did in the alert PR).

Review

@sgiehl commented on September 29th 2021 Member

@diosmosis would it make sense to also have a test that checks that the built vue files are up to date? Wondering if it otherwise could happen that someone changes a vue component but forgets to update or push the umd files. 🤔

@diosmosis commented on September 29th 2021 Member

@sgiehl That sounds like a good idea... I guess it could be done by checking if the diff w/ 4.x-dev has changes to vue/src files, and making sure there are also changes to vue/dist. But that wouldn't be foolproof since a dev could forget to compile after making an additional source code change.

Alternatively we could modify the travis-scripts to run the build command (after doing an npm install) and checking that nothing was modified. What do you think?

@sgiehl commented on October 1st 2021 Member

Not sure if adding that to travis is a good option. Personally I would prefer moving such stuff to a github action. Similar to the PHPCS the action could simply run building the vue js files and check if there would be any changes available. That way we could even enforce the check and a PR couldn't be merged anymore if the files aren't up to date.

@diosmosis commented on October 2nd 2021 Member

@sgiehl ok, i'll look into using a github action.

@github-actions[bot] commented on October 10th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@tsteur commented on October 11th 2021 Member

@diosmosis can we merge this already or do we need to wait for the github action?

@diosmosis commented on October 11th 2021 Member

@tsteur the github action will prevent more issues so I'll still look into that.

@diosmosis commented on October 12th 2021 Member

Closing in favor of https://github.com/matomo-org/matomo/pull/18080 which will rebuild vue files automatically.

This Pull Request was closed on October 12th 2021
Powered by GitHub Issue Mirror