To catch when someone pushes a development build of a UMD module (as I did in the alert PR).
@diosmosis would it make sense to also have a test that checks that the built vue files are up to date? Wondering if it otherwise could happen that someone changes a vue component but forgets to update or push the umd files. 🤔
@sgiehl That sounds like a good idea... I guess it could be done by checking if the diff w/ 4.x-dev has changes to
vue/src files, and making sure there are also changes to
vue/dist. But that wouldn't be foolproof since a dev could forget to compile after making an additional source code change.
Alternatively we could modify the travis-scripts to run the build command (after doing an npm install) and checking that nothing was modified. What do you think?
Not sure if adding that to travis is a good option. Personally I would prefer moving such stuff to a github action. Similar to the PHPCS the action could simply run building the vue js files and check if there would be any changes available. That way we could even enforce the check and a PR couldn't be merged anymore if the files aren't up to date.
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers
@diosmosis can we merge this already or do we need to wait for the github action?
@tsteur the github action will prevent more issues so I'll still look into that.
Closing in favor of https://github.com/matomo-org/matomo/pull/18080 which will rebuild vue files automatically.