Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Migrate piwik-alert directive to Vue component #18075

Merged
merged 6 commits into from Sep 30, 2021
Merged

Conversation

diosmosis
Copy link
Member

Description:

This PR migrates the piwik-alert directive to Vue and serves as an example/reference for how to handle AngularJS transclusion into Vue components.

Asset Sizes

image

image

Review

@diosmosis diosmosis added this to the 4.6.0 milestone Sep 29, 2021
@diosmosis diosmosis added the Needs Review PRs that need a code review label Sep 29, 2021
@sgiehl sgiehl merged commit c69f12a into 4.x-dev Sep 30, 2021
@sgiehl sgiehl deleted the vue-migrate-alert branch September 30, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants