Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FakePluginList to help with plugin tests #18072

Closed
wants to merge 2 commits into from
Closed

Conversation

JasonMortonNZ
Copy link
Contributor

Description:

Issue: dev-2082

This PR updates a test helper class to enable plugin sorting during tests.

Review

@JasonMortonNZ JasonMortonNZ added the Needs Review PRs that need a code review label Sep 28, 2021
@JasonMortonNZ JasonMortonNZ added this to the 4.5.0 milestone Sep 28, 2021
@tsteur
Copy link
Member

tsteur commented Sep 28, 2021

@JasonMortonNZ can we also include the other changes in here for the container builder?

*/
private function sortPlugins(array $plugins)
{
return call_user_func($GLOBALS['MATOMO_SORT_PLUGINS'], $plugins);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be great to leave a comment it's for cloud

@sgiehl sgiehl deleted the dev-2082 branch April 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants