New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide console command for adding a marketplace license key (#18070) #18071
Provide console command for adding a marketplace license key (#18070) #18071
Conversation
The failing checks do not seem to be related to my change. |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
@ziegenberg I see this PR is in draft. Not sure if that was you? Is that ready for a review? |
Hi @tsteur, I left this in the draft state because it is most certainly not ready yet and I wanted to discuss my implementation before going to review. I suspect that I have misinterpreted the workflow here... |
@ziegenberg this looked all good to me. I would maybe just rename the command to be |
So you don't want to add any checks for validity while setting the license key? |
849d26b
to
00c849a
Compare
I quickly made the suggested changes and rebased onto current 4.x-dev |
@ziegenberg it depends what you are using the command for and how quick things need to go as the validation will take a bit of time. We have an API that you can use like This API won't "remove/unset" the license key though. If an empty license key is provided, then you would need to call the API method Overall this would be better indeed 👍 |
00c849a
to
1110c07
Compare
* adds a new console command marketplace:set-license-key which sets a marketplace license key Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
1110c07
to
1af77be
Compare
@tsteur I added the checks using the API. Does this look good to you? |
Nice, that looks good and works nicely 👍 Thanks for that. |
Description:
Adds a new console command marketplace:add-license-key which adds a marketplace license key (Fixes #18070)
This is the first draft. It does not implement any checks like it's done in the Marketplace API:
matomo/plugins/Marketplace/API.php
Lines 69 to 95 in 2ac2bc1
I'd need some pointers for further implementing this, if checking the license key this is deemed necessary.
Review