@justinvelluppillai opened this Pull Request on September 26th 2021 Contributor

Description:

fixes #17589

Recreating #18014 to fix travis build errors.

Review

@Findus23 commented on October 1st 2021 Member

@justinvelluppillai Maybe I am missing something obvious, but doesn't this change still make the requests if they are disabled and just removes the end result from the display?

If so, it doesn't help with https://github.com/matomo-org/matomo/issues/17589, right?

@justinvelluppillai commented on October 2nd 2021 Contributor

@Findus23 it doesn't make any requests if the config is set to 0, it returns early before computeAccessiblePaths() is called.

@Findus23 commented on October 2nd 2021 Member

@justinvelluppillai You are right. Sorry, I completly misread the changes.

This Pull Request was closed on September 27th 2021
Powered by GitHub Issue Mirror