Transition data exporting #18062
Merged
Transition data exporting #18062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
added
the
not-in-changelog
sgiehl
requested changes
Sep 27, 2021
There was a problem hiding this comment.
Generally seems to work.
Btw. did you try reusing the report export we already have?
See
matomo/plugins/CoreHome/templates/_dataTableActions.twig
Lines 57 to 62 in b66635e
Guess it would need various adjustments, as it currently depends on a datatable, which we don't have for transitions. Also there are some configuration that would need to be hidden, as they aren't relevant here. But it basically does the same and would also allow to see the export url.
plugins/Transitions/angularjs/transitionexporter/transitionexporter.directive.js
Show resolved
Hide resolved
Use var instead of let Co-authored-by: Stefan Giehl <stefan@matomo.org>
tsteur
requested changes
Oct 5, 2021
plugins/Transitions/angularjs/transitionexporter/transitionexporter.directive.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #6032
Visualisations and the standard report exporter expect a single datatable structure, so instead of wrapping the transitions in a visualisation, this change adds a new transition exporter directive which provides an export action on both the main transitions map view and on transitions shown by row actions. This export action then calls the API to return the data in the chosen export format.
Review