Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php binary format check #18060

Merged
merged 14 commits into from Oct 5, 2021
Merged

add php binary format check #18060

merged 14 commits into from Oct 5, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Sep 24, 2021

Description:

Fixes: #18058
add os format check on installation, recommended 64 bit

Review

Peter Zhang and others added 2 commits September 24, 2021 15:34
add os format check, recommended 64 bit
update image on diagnostics
@peterhashair peterhashair linked an issue Sep 24, 2021 that may be closed by this pull request
@peterhashair peterhashair marked this pull request as ready for review September 24, 2021 05:18
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 24, 2021
@peterhashair peterhashair modified the milestones: 4.5.0, 4.8.0 Sep 24, 2021
@peterhashair
Copy link
Contributor Author

@sgiehl Yeah, sorry for my english. Iit's really hard to figure out ,if a webserver x86 runining on WOW64bit by php, or it could be 64 bit of website server but 32 bit version of php. I guess the OS format check is not a propery word. maybe like @Findus23 suggest 64-bit PHP Binary is a better term. What's your suggest?

@sgiehl
Copy link
Member

sgiehl commented Sep 24, 2021

64-bit PHP Binary should be fine

Peter Zhang added 2 commits September 25, 2021 21:12
update wording
update language
Peter Zhang added 3 commits September 27, 2021 10:52
update english on system format 32 bit
update screen shot of install
plugins/Installation/lang/en.json Outdated Show resolved Hide resolved
plugins/Diagnostics/Diagnostic/SystemFormatCheck.php Outdated Show resolved Hide resolved
@sgiehl sgiehl changed the title add os format check add php binary format check Sep 27, 2021
Peter Zhang added 3 commits September 28, 2021 03:17
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests seem to be unrelated, so should be good to merge now.

Peter Zhang added 3 commits September 28, 2021 09:29
update php binary check helper
# Conflicts:
#	plugins/Diagnostics/tests/UI/expected-screenshots/Diagnostics_page.png
@peterhashair peterhashair removed this from the 4.8.0 milestone Oct 4, 2021
@peterhashair peterhashair added this to the 4.6.0 milestone Oct 4, 2021
@peterhashair
Copy link
Contributor Author

@tsteur can I merge that one?

@tsteur
Copy link
Member

tsteur commented Oct 5, 2021

Yes @peterhashair 👍

@peterhashair peterhashair merged commit 4196894 into 4.x-dev Oct 5, 2021
@peterhashair peterhashair deleted the m-18058-add-os-check branch October 5, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add system check for 32 bit PHP / OS
5 participants