New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add php binary format check #18060
add php binary format check #18060
Conversation
add os format check, recommended 64 bit
update image on diagnostics
@sgiehl Yeah, sorry for my english. Iit's really hard to figure out ,if a webserver x86 runining on WOW64bit by php, or it could be 64 bit of website server but 32 bit version of php. I guess the OS format check is not a propery word. maybe like @Findus23 suggest 64-bit PHP Binary is a better term. What's your suggest? |
|
update wording
update language
update english on system format 32 bit
update screen shot of install
update system check to php binary check
update translation key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests seem to be unrelated, so should be good to merge now.
update php binary check helper
# Conflicts: # plugins/Diagnostics/tests/UI/expected-screenshots/Diagnostics_page.png
@tsteur can I merge that one? |
Yes @peterhashair 👍 |
Description:
Fixes: #18058
add os format check on installation, recommended 64 bit
Review