Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system check for 32 bit PHP / OS #18058

Closed
tsteur opened this issue Sep 23, 2021 · 1 comment · Fixed by #18060
Closed

Add system check for 32 bit PHP / OS #18058

tsteur opened this issue Sep 23, 2021 · 1 comment · Fixed by #18060
Assignees
@peterhashair
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.6.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 23, 2021 •
edited

refs #18019

Let's add a system check if a 32 bit PHP is used and mention we recommend upgrading to a 64 bit to prevent various issues that may come up in the future.

Not sure how many possible integer overflows there are so far in Matomo. We need to do a quick check as part of this issue to know if there might be already issues with 32 bit in PHP by looking through the code (like finding places where we do time() + ...

Does anyone know how common 32 bit installs are these days?
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Sep 23, 2021
@tsteur tsteur added this to the 4.8.0 milestone Sep 23, 2021
@peterhashair peterhashair self-assigned this Sep 24, 2021
@peterhashair peterhashair linked a pull request Sep 24, 2021 that will close this issue
add php binary format check #18060
Merged
11 tasks
@Findus23
Copy link
Member

Does anyone know how common 32 bit installs are these days?

For reference: Of all Debian users who have popcon enabled (https://popcon.debian.org/), 190502 use amd64 while 14218 use 1386. But the number is decreasing quite rapidly.

@peterhashair peterhashair mentioned this issue Oct 4, 2021
Merged
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.8.0, 4.5.0 Oct 7, 2021
@justinvelluppillai justinvelluppillai modified the milestones: 4.5.0, 4.6.0 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

add php binary format check matomo-org/matomo
4 participants
@tsteur @justinvelluppillai @peterhashair @Findus23