New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add last seen to the UserManager Api #18053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add last seen to the UserManager Api
reverse format change
fix a typo
update array index
peterhashair
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Sep 23, 2021
remove an accidentaly copy and paste
peterhashair
removed
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Sep 23, 2021
update file
reverse update
update Unit Test
…rg/matomo into m-10550-api-user-lastseen-field
peterhashair
added
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
labels
Sep 23, 2021
For the api date_last_seen maybe is not a propery word, if we addt ime onto as its value. Suggest use last_seen if we want to use time, or we can remove the time, date_last_seen=date. Also for the time zone , should I use gmdate or just use date. |
sgiehl
requested changes
Sep 24, 2021
Co-authored-by: Stefan Giehl <stefan@matomo.org>
update api field date_last_seen to last_seen, fixed some code format, change gdate to date
sgiehl
reviewed
Sep 27, 2021
update date to Piwik date function
sgiehl
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
add the last seen field to the UserManager.getUsers Api.
File change
Review