Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2-lines label overflows the input on small device #18052

Merged
merged 6 commits into from Oct 7, 2021
Merged

2-lines label overflows the input on small device #18052

merged 6 commits into from Oct 7, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Sep 23, 2021 •
edited

Description:

Fixes #17602

This PR fix 2 line input overlap on the small screen device by adding CSS line-height. It will affect 2 submodule screenshot tests

  • QueueTracking PR
  • AnonymousPiwikUsageMeasurement PR

Review

update css
b222f9a 
update css
@peterhashair peterhashair added this to the 4.5.0 milestone Sep 23, 2021
@peterhashair peterhashair linked an issue Sep 23, 2021 that may be closed by this pull request
Fix 2-lines label overflows the input #17602
Closed
@peterhashair peterhashair changed the title update css update 'i' icon css Sep 26, 2021
@peterhashair peterhashair changed the title update 'i' icon css update input overlapping on small device Sep 27, 2021
@peterhashair peterhashair modified the milestones: 4.5.0, 4.6.0 Sep 27, 2021
@peterhashair peterhashair changed the title update input overlapping on small device 2-lines label overflows the input on small device Sep 28, 2021
@peterhashair peterhashair marked this pull request as ready for review September 29, 2021 06:26
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 29, 2021
@peterhashair peterhashair mentioned this pull request Oct 7, 2021
Merged
11 tasks
update subModule
72e755e 
update subModule commit Number
@peterhashair peterhashair mentioned this pull request Oct 7, 2021
Merged
11 tasks
@tsteur tsteur merged commit 41992ce into 4.x-dev Oct 7, 2021
@tsteur tsteur deleted the m-17602-update-2-lines-css branch October 7, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Fix 2-lines label overflows the input
2 participants
@peterhashair @tsteur