Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update admin level, user manage text #18050

Merged
merged 5 commits into from Sep 28, 2021
Merged

update admin level, user manage text #18050

merged 5 commits into from Sep 28, 2021

Conversation

peterhashair
Copy link
Contributor

Description:

update admin level, user manager hints text

Review

update admin level, user manage text
149b7b8 
update admin level, user manage text
@peterhashair peterhashair added this to the 4.5.0 milestone Sep 23, 2021
@peterhashair peterhashair linked an issue Sep 23, 2021 that may be closed by this pull request
Manage Users: When user is admin, mention other users might exist #17996
Closed
update admin view
ed59292 
update admin view
@peterhashair peterhashair marked this pull request as ready for review September 24, 2021 01:16
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 24, 2021
@peterhashair @sgiehl
Update plugins/UsersManager/lang/en.json
171f436 
update text

Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl
Copy link
Member

sgiehl commented Sep 27, 2021

Guess the UI screenshots will need another update. Besides that it should be good to merge I guess.

@peterhashair
Copy link
Contributor Author

@sgiehl updated it, but it seems like there is a test that failed is not relevant to that one request

@sgiehl sgiehl merged commit 6130619 into 4.x-dev Sep 28, 2021
@sgiehl sgiehl deleted the m-17996-change-admin-add-user-text branch September 28, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Manage Users: When user is admin, mention other users might exist
2 participants
@peterhashair @sgiehl