Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed files related to unsupported databases #18042

Merged
merged 4 commits into from Sep 22, 2021
Merged

removed files related to unsupported databases #18042

merged 4 commits into from Sep 22, 2021

Conversation

peterhashair
Copy link
Contributor

Description:

Removed Mssql and pgsql driver, which are not in used.

Review

removed Mssql and pgsql
0453129 
removed Mssql and pgsql driver
@peterhashair peterhashair linked an issue Sep 21, 2021 that may be closed by this pull request
Remove not used DB adapters #18039
Closed
@peterhashair peterhashair added this to the 4.7.0 milestone Sep 21, 2021
@peterhashair peterhashair marked this pull request as ready for review September 22, 2021 00:36
@peterhashair peterhashair added the Needs Review PRs that need a code review label Sep 22, 2021
@tsteur
Copy link
Member

tsteur commented Sep 22, 2021

@peterhashair can you also remove a few other references related to these?

For example
image

eg there is a setting minimum_pgsql_version which was used by the pgsql adapter which is no longer needed.

We can also remove the comment in Adapter.php that says "other adapters supported by Zend_Db (can remove all the commented adapters)

image

There is also a file core/Tracker/Db/Pdo/Pgsql.php which we can remove.

update comments contain pgsql
95cac5c 
update comments contain pgsql
@peterhashair
Copy link
Contributor Author

@tsteur sorry about that should be removed now.

Update UIIntegrationTest_admin_diagnostics_configfile.png
7fb6743 
because of minimum_pgsql_version removed change config image.
@tsteur
Copy link
Member

tsteur commented Sep 22, 2021

@peterhashair There is also a file core/Tracker/Db/Pdo/Pgsql.php which we can remove. Otherwise looks so far good to merge.

remove pgsql
415bdd2 
remove pgsql
@peterhashair
Copy link
Contributor Author

@tsteur sorry about that I saw that one, I was thought we just not using the customer driver but zend driver, read the support docs again, we don't support Postgresql at all. Should I remove libs/Zend/Db/Adapter/Pdo/Pgsql.php as well?

@tsteur
Copy link
Member

tsteur commented Sep 22, 2021

We can keep the other zend file as it's part of the zend library 👍

@tsteur tsteur merged commit 0adaea4 into 4.x-dev Sep 22, 2021
@tsteur tsteur deleted the m-18039-remove-used-db-adapters branch September 22, 2021 04:17
@justinvelluppillai justinvelluppillai changed the title removed Mssql and pgsql removed files related to unsupported databases Oct 6, 2021
@justinvelluppillai justinvelluppillai modified the milestones: 4.7.0, 4.5.0 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Remove not used DB adapters
3 participants
@peterhashair @tsteur @justinvelluppillai