@peterhashair opened this Pull Request on September 21st 2021 Contributor

Description:

Removed Mssql and pgsql driver, which are not in used.

Review

@tsteur commented on September 22nd 2021 Member

@peterhashair can you also remove a few other references related to these?

For example
image

eg there is a setting minimum_pgsql_version which was used by the pgsql adapter which is no longer needed.

We can also remove the comment in Adapter.php that says "other adapters supported by Zend_Db (can remove all the commented adapters)

image

There is also a file core/Tracker/Db/Pdo/Pgsql.php which we can remove.

@peterhashair commented on September 22nd 2021 Contributor

@tsteur sorry about that should be removed now.

@tsteur commented on September 22nd 2021 Member

@peterhashair There is also a file core/Tracker/Db/Pdo/Pgsql.php which we can remove. Otherwise looks so far good to merge.

@peterhashair commented on September 22nd 2021 Contributor

@tsteur sorry about that I saw that one, I was thought we just not using the customer driver but zend driver, read the support docs again, we don't support Postgresql at all. Should I remove libs/Zend/Db/Adapter/Pdo/Pgsql.php as well?

@tsteur commented on September 22nd 2021 Member

We can keep the other zend file as it's part of the zend library 👍

This Pull Request was closed on September 22nd 2021
Powered by GitHub Issue Mirror