Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used DB adapters #18039

Closed
tsteur opened this issue Sep 21, 2021 · 1 comment · Fixed by #18042
Closed

Remove not used DB adapters #18039

tsteur opened this issue Sep 21, 2021 · 1 comment · Fixed by #18042
Assignees
@peterhashair
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.5.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 21, 2021

Meaning https://github.com/matomo-org/matomo/blob/4.5.0-b2/core/Db/Adapter/Pdo/Mssql.php and https://github.com/matomo-org/matomo/blob/4.5.0-b2/core/Db/Adapter/Pdo/Pgsql.php

Since these are not supported can we remove them? It requires us on occasion to add core to these classes when we add methods to the other adapters and it confuses new developers thinking we might support them and that they need to be tested.

@mattab @sgiehl or do you know any reason why they still exist in the code?
@tsteur tsteur added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Sep 21, 2021
@tsteur tsteur added this to the 4.7.0 milestone Sep 21, 2021
@sgiehl
Copy link
Member

sgiehl commented Sep 21, 2021

@tsteur can't think of any useful reason. Couldn't even find a reason in git history why they had been added...

@peterhashair peterhashair self-assigned this Sep 21, 2021
@peterhashair peterhashair linked a pull request Sep 21, 2021 that will close this issue
removed files related to unsupported databases #18042
Merged
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.7.0, 4.5.0 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

removed files related to unsupported databases matomo-org/matomo
4 participants
@tsteur @justinvelluppillai @sgiehl @peterhashair