add warning about dropping support for users using IE #18037
Conversation
There was a problem hiding this comment.
Worked nicely for me 👍 Left only a minor comment.
@sgiehl did you want to have a look as well re the user agent?
It's shown everywhere including login screen etc 👍
I'll create also a follow up issue for Matomo 4.7 to remove this check again as it won't be needed anymore once they no longer work together.
Co-authored-by: Thomas Steur <tsteur@users.noreply.github.com>
plugins/CoreHome/lang/en.json
Outdated
| @@ -123,6 +123,7 @@ | |||
| "SoftwareSubcategoryHelp": "The Software section shows the operating systems, browsers and plugins that your visitors are using to access the site so that you can optimise your site to ensure it is fully compatible with the most popular configurations.", | |||
| "EngagementSubcategoryHelp1": "The Engagement section provides reports that help to quantify how many new and returning visitors you get. You can also review reports that break down the average time and number of pages per visit, as well as the number of times a visitor has been to your site and the most common number of days between visits.", | |||
| "EngagementSubcategoryHelp2": "This can help you to optimise for frequency and high-interaction visits in addition to maximising your reach.", | |||
| "PeriodHasOnlyRawData": "It looks like reports for this period have not been processed yet. Do you want to see what's happening now? Check out the %1$sVisits log%2$s or choose a different date period until the reports are generated." | |||
| "PeriodHasOnlyRawData": "It looks like reports for this period have not been processed yet. Do you want to see what's happening now? Check out the %1$sVisits log%2$s or choose a different date period until the reports are generated.", | |||
| "InternetExplorer11Warning": "Starting in version Matomo 4.6, Matomo will be ending support for Internet Explorer. For more information %1$ssee our blog post.%2$s" | |||
There was a problem hiding this comment.
| "InternetExplorer11Warning": "Starting in version Matomo 4.6, Matomo will be ending support for Internet Explorer. For more information %1$ssee our blog post.%2$s" | |
| "InternetExplorer11Warning": "Starting in version Matomo 4.6, Matomo will be ending support for Internet Explorer. For more information %1$ssee our blog post%2$s." |
There was a problem hiding this comment.
Just out of curiosity: Is it even worth to get this translated? I guess it will only be shown for Matomo 4.5 and be removed in 4.7. So before it might receive translations at all it might be removed again...
There was a problem hiding this comment.
Then again, there might be a lot of Matomo users who don't speak English and are confused by a permanent warning they can't remove.
There was a problem hiding this comment.
Wondering if we maybe should use a more reusable translation in that case. Something like Starting in version Matomo %1$s, Matomo will be ending support for %2$s. For more information %3$ssee our blog post%4$s.. That way we could maybe reuse it at some point when we either drop support for PHP 7.x or any older MySQL version maybe
There was a problem hiding this comment.
It's trivial to add a new translation, isn't it? I don't think this is necessary.
There was a problem hiding this comment.
I think @sgiehl meant so it's translated next time we need this again. Like if we release next Matomo in 1 week then translators have only 1 week or less to translate it into few languages. Overall it's not 100% needed like we might even remove that translation key again by accident or who knows if we'll remember that string is there etc. But could also change it. Personally I have no preference.
justinvelluppillai
added
the
not-in-changelog
* Revert "add warning about dropping support for users using IE (#18037)" This reverts commit 962bd82. * Mark IE11 as unsupported browser * update browserslist dependencies to > 0.05% usage * update other browser versions * debug browser not supported ui test failure * reset user agent in optoutform UI test * reset user agent after optoutform test * another user agent in tests tweak * remove supported browser debugging output Co-authored-by: diosmosis <diosmosis@users.noreply.github.com>
Description:
As title, the notification will only display when on IE.
Refs #18012
Review