Icon for "Report generated X min ago" displayed for "Today" is too small #18035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update icon and css
update all interface has question mark to info mark
update one image contain icons
peterhashair
force-pushed
the
m-17815-icon-size
branch
from
26a244f
to
e2638cb
Compare
peterhashair
added
Needs Review
peterhashair
changed the title
# Conflicts: # plugins/UsersManager/tests/UI/expected-screenshots/UsersManager_admin_view_admin_add_user_by_email.png # plugins/UsersManager/tests/UI/expected-screenshots/UsersManager_admin_view_admin_add_user_by_login.png # plugins/UsersManager/tests/UI/expected-screenshots/UsersManager_admin_view_admin_add_user_not_exists.png # plugins/UsersManager/tests/UI/expected-screenshots/UsersManager_admin_view_admin_load.png # plugins/UsersManager/tests/UI/expected-screenshots/UsersManager_permissions_bulk_access_set.png
justinvelluppillai
suggested changes
Sep 30, 2021
There was a problem hiding this comment.
@peterhashair I think @tsteur mentions in the issue we want to move the date information into the ? icon tooltip text, and use the i icon instead of the ? icon, also remove the smaller icon. I don't think we want to override the help icon to show the info icon as we will likely want to use it elsewhere (and maybe already do). Can you take a look at #17815 (comment)
added 3 commits
October 1, 2021 11:50
only update icon on widgets, and remove today function
update help tooltip
|
@justinvelluppillai that makes more sense. updated it, should be fine now |
plugins/CoreHome/angularjs/enrichedheadline/enrichedheadline.directive.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good and works here - @tsteur maybe good if you take a look also to make sure it's the expected solution.
added 2 commits
October 4, 2021 15:49
|
@justinvelluppillai that make code way much cleaner. :) |
remove if to inline if
|
Looks good to me @peterhashair @justinvelluppillai 👍 |
justinvelluppillai
approved these changes
Oct 4, 2021
added 2 commits
October 4, 2021 17:51
# Conflicts: # tests/UI/expected-screenshots/UIIntegrationTest_category_help.png
update screen shots
This was referenced Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #17815
Update Icon on the report widgets. Please be aware of the icon with '?' with transferred to icon 'i'. Let me know if that's invalid
Review