Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback to mt_rand and always use random_int for secure randomness #18030

Merged
merged 2 commits into from Sep 19, 2021

Conversation

Findus23
Copy link
Member

Description:

fixes #9473

Review

@Findus23 Findus23 added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Sep 19, 2021
@tsteur tsteur added this to the 4.5.0 milestone Sep 19, 2021
@tsteur tsteur merged commit 81cb72e into 4.x-dev Sep 19, 2021
@tsteur tsteur deleted the secure-randomness branch September 19, 2021 22:20
@justinvelluppillai justinvelluppillai changed the title Always use secure randomness Remove fallback to mt_rand and always use random_int for secure randomness Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using secure random numbers
2 participants