add heartbeat ping tab tracking #18028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhashair
added
not-in-changelog
tsteur
reviewed
Sep 17, 2021
tsteur
reviewed
Sep 17, 2021
peterhashair
force-pushed
the
m-16459-heartbeat-trigger
branch
3 times, most recently
from
84a8cd3
to
302a7ef
Compare
peterhashair
force-pushed
the
m-16459-heartbeat-trigger
branch
from
302a7ef
to
5a5da64
Compare
|
build js |
|
Nice, worked 👍 also tested some IEs etc. |
paladox
reviewed
Oct 7, 2021
| } else if (windowAlias.detachEvent) { | ||
| windowAlias.detachEvent('onfocus', heartBeatOnFocus); | ||
| windowAlias.detachEvent('onblur', heartBeatOnBlur); | ||
| windowAlias.removeEventListener('visibilitychange', heartBeatOnVisible); |
There was a problem hiding this comment.
Shouldn't this be detachEvent?
|
@paladox thanks for that, you are absolutely right. Let me do a quick fix for that. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the user comes back to the original tab, will send a ping request again.
Review