@mwithheld opened this Pull Request on September 17th 2021 Contributor

Description

Fixes #11796 E-Mail addresses with special characters are not working by unsanitizing the email address before adding/updating user info. Added tests for several unusual but valid email addresses.

@sgiehl commented on September 24th 2021 Member

It's annoying that Travis doesn't seem to build some Pull Requests from forks currently. I have pushed the changes of this PR together with latest changes from 4.x-dev into a local branch. So we can see the Travis Build results. See https://app.travis-ci.com/github/matomo-org/matomo/builds/238438467

@github-actions[bot] commented on October 2nd 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@sgiehl commented on October 26th 2021 Member

@mwithheld I have pushed the changes to a local branch in order to get the tests running (See https://app.travis-ci.com/github/matomo-org/matomo/jobs/545171822). It seems your branch name causes some trouble on travis, as a numeric branch name can be interpreted as commit hash. For future PRs maybe prefix the branches with fix or something like that, so we directly can see if tests are passing.

Could you also please merge in the latest changes from 4.x-dev. The XssTesting class needs an adjustment, but there were changes on that file on 4.x-dev that might cause merge conflict if we change it in this PR now.

@mwithheld commented on October 29th 2021 Contributor

Too bad renaming the branch doesn't help.

@sgiehl commented on October 29th 2021 Member

@mwithheld closing this pull request and opening a new one from another branch might help

@github-actions[bot] commented on November 13th 2021 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions[bot] commented on December 26th 2021 Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

Powered by GitHub Issue Mirror