Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note to config that MYSQLI isn't supported for max execution #18018

Merged
merged 4 commits into from Sep 17, 2021

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Sep 16, 2021

Description:

Fixes #17871

Added a note to both max execution time settings in global.ini.php to explain that these settings are not supported for the MYSQLI extension.

Review

@bx80 bx80 added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 16, 2021
@tsteur
Copy link
Member

tsteur commented Sep 16, 2021

@tsteur
Copy link
Member

tsteur commented Sep 16, 2021

@bx80 sorry I think after merging 4.x in there the test is now failing again as a language was added in 4.x see https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/49116/UIIntegrationTest_admin_diagnostics_configfile.png
image

@tsteur tsteur merged commit 897f4ef into 4.x-dev Sep 17, 2021
@tsteur tsteur deleted the m-17871-max-execution-mysqli branch September 17, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added info message that INI setting archiving_query_max_execution_time may not work for MySQLI
2 participants