@geekdenz opened this Pull Request on September 16th 2021 Contributor

Description:

Not super beautiful fix, but it works.

Review

@tsteur commented on September 16th 2021 Member

@geekdenz did you have a look at @sgiehl comment in https://github.com/matomo-org/matomo/pull/17987#issuecomment-920095127 ? Did changing this one to true maybe not fix the problem?

@geekdenz commented on September 16th 2021 Contributor

@tsteur I already checked his comment and fixed it here:
https://github.com/matomo-org/matomo/commit/24a4cfe9c1b506aa7bcf8ac3bc61366e8bfac24c
Did you see that or is there something wrong with the fix?

@geekdenz commented on September 16th 2021 Contributor

build js

@geekdenz commented on September 16th 2021 Contributor
@geekdenz commented on September 16th 2021 Contributor

Sorry, @sgiehl and thanks for the suggestion.

@tsteur commented on September 17th 2021 Member

I'll close https://github.com/matomo-org/matomo/issues/17965

fyi @geekdenz if you put fix <a href='/17965'>#17965</a> in the PR description then it will close the related issue automatically when merging.

This Pull Request was closed on September 17th 2021
Powered by GitHub Issue Mirror