Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass phpunit filter directly when running tests using tests:run command #18015

Merged
merged 1 commit into from Sep 16, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 16, 2021

Description:

If someone is used to write --filter="..." in phpunit then this will be more natural. I'm always writing --options="--filter=..." so far but now it can be used directly. Once merged will document this.

Review

@tsteur tsteur added the Needs Review PRs that need a code review label Sep 16, 2021
@tsteur tsteur added this to the 4.5.0 milestone Sep 16, 2021
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 16, 2021
@tsteur tsteur changed the title Add option to pass phpunit filter directly Add option to pass phpunit filter directly when running tests using tests:run command Sep 16, 2021
@tsteur tsteur merged commit e71ced0 into 4.x-dev Sep 16, 2021
@tsteur tsteur deleted the filtertests branch September 16, 2021 21:10
tsteur added a commit to matomo-org/developer-documentation that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants