The SEO test fails consistently here, but this seems to have nothing to do with this PR.
Just out of curiosity: Why do we need an option to disable certain diagnostic checks? If someone wants to remove the private directory checks he can simply achieve that by creating a
config\config.php with this content:
return [ 'diagnostics.disabled' => DI\add([ DI\get(\Piwik\Plugins\Diagnostics\Diagnostic\RequiredPrivateDirectories::class), DI\get(\Piwik\Plugins\Diagnostics\Diagnostic\RecommendedPrivateDirectories::class), ]) ];
@sgiehl we usually don't ask users to edit
config.php if it can be avoided. The ini file is a lot easier to change for people, especially non-technical people. And once they have more entries in
config.php it may be easy for them to break things. Also this way it's independent of code. Like recently we changed class names for these and then it wouldn't work anymore or even the entire Matomo could break if we removed these classes maybe as the files would no longer exist.
I think this might be unrelated: https://builds-artifacts.matomo.org/matomo-org/matomo/m-17589-4.x-dev/49276/UsersManager_permissions_bulk_access_set.png
@geekdenz this looks good to merge.
For some reason thought the PR build always fails see eg https://app.travis-ci.com/github/matomo-org/matomo/jobs/539047123#L1189
and also in the previous run see https://app.travis-ci.com/github/matomo-org/matomo/builds/238279592
Not sure if there went something wrong with .gitmodules etc. It says:
@bx80 experienced this recently as well and fixed it with https://developer.matomo.org/guides/git#fixing-the-error-fatal-remote-error-upload-pack-not-our-ref