New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable http requests on config #18014
Conversation
The SEO test fails consistently here, but this seems to have nothing to do with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity: Why do we need an option to disable certain diagnostic checks? If someone wants to remove the private directory checks he can simply achieve that by creating a return [
'diagnostics.disabled' => DI\add([
DI\get(\Piwik\Plugins\Diagnostics\Diagnostic\RequiredPrivateDirectories::class),
DI\get(\Piwik\Plugins\Diagnostics\Diagnostic\RecommendedPrivateDirectories::class),
])
]; |
@sgiehl we usually don't ask users to edit |
I think this might be unrelated: https://builds-artifacts.matomo.org/matomo-org/matomo/m-17589-4.x-dev/49276/UsersManager_permissions_bulk_access_set.png |
@geekdenz this looks good to merge. For some reason thought the PR build always fails see eg https://app.travis-ci.com/github/matomo-org/matomo/jobs/539047123#L1189 and also in the previous run see https://app.travis-ci.com/github/matomo-org/matomo/builds/238279592 Not sure if there went something wrong with .gitmodules etc. It says: @bx80 experienced this recently as well and fixed it with https://developer.matomo.org/guides/git#fixing-the-error-fatal-remote-error-upload-pack-not-our-ref |
Description:
fixes #17589
Review