Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about dropping support for IE11 in Matomo user interface #18012

Closed
tsteur opened this issue Sep 15, 2021 · 3 comments
Closed

Add warning about dropping support for IE11 in Matomo user interface #18012

tsteur opened this issue Sep 15, 2021 · 3 comments
Assignees
@diosmosis
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.5.0

Comments

@tsteur
Copy link
Member

tsteur commented Sep 15, 2021

We are using Angular.JS library which soon will be no longer receiving updates. This forces us to upgrade to either a newer version of Angular or an alternative library. We've chosen to migrate all our Angular.js components to Vue.js 3 starting in #17940

Unfortunately, Vue.js 3 is not supporting IE 11. This means we have no choice but to drop support for IE11 as well. This follows Microsoft who is dropping support for IE11 and WordPress.

This only applies to the Matomo user interface but not to the Matomo JavaScript tracker which will still support this browser and older IE versions.

To make users aware of this upcoming change, we should show a notification in the reporting and the admin UI that support for this version will soon be dropped. For the admin part we could do it similar to https://github.com/matomo-org/matomo/blob/4.5.0-b1/core/Plugin/ControllerAdmin.php#L247 . For the UI part we probably need to show that notification somewhere else. We would only show this if IE11 is used.

We should also write a blog post announcing this eg similar to how WordPress did and link to that blog from the notification.

It's not clear yet if some next versions of Matomo will still partially work with IE11 or whether it will not work anymore at all.

Created also a follow up issue to at the latest in Matomo 5.0 mark the browser as no longer supported: #18011
@tsteur tsteur added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. labels Sep 15, 2021
@tsteur tsteur added this to the 4.5.0 milestone Sep 15, 2021
@diosmosis diosmosis self-assigned this Sep 16, 2021
@tsteur
Copy link
Member Author

tsteur commented Sep 21, 2021

@diosmosis published https://matomo.org/blog/2021/09/matomo-to-end-support-for-internet-explorer-11/ which we can link to. Will you add the notifications? To be a bit faster we could only do the browser detection for IE 11 if the user agent contains Windows and 11 maybe? see https://www.whatismybrowser.com/guides/the-latest-user-agent/internet-explorer the user agent would typically look somewhat like Mozilla/5.0 (Windows NT 10.0; Trident/7.0; rv:11.0) like Gecko. Or maybe we could reuse the result from https://github.com/matomo-org/matomo/blob/4.5.0-b2/core/SupportedBrowser.php#L51 somehow?

@diosmosis
Copy link
Member

@tsteur working on it now. I was thinking of just checking and adding the notification via JavaScript. What do you think?

@diosmosis diosmosis mentioned this issue Sep 21, 2021
Merged
11 tasks
@tsteur
Copy link
Member Author

tsteur commented Sep 21, 2021

Sounds good to me 👍 PR looks good to merge just waiting for @sgiehl to confirm in case he notices anything with user agent check

@tsteur tsteur closed this as completed Sep 21, 2021
@justinvelluppillai justinvelluppillai changed the title Dropping support for IE11 Add warning about dropping support for IE11 in Matomo user interface Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.5.0
Development

No branches or pull requests
2 participants
@diosmosis @tsteur