Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System check widget shows wrong database warning #18006

Closed
BigBerny opened this issue Sep 15, 2021 · 5 comments · Fixed by #18029
Closed

System check widget shows wrong database warning #18006

BigBerny opened this issue Sep 15, 2021 · 5 comments · Fixed by #18029
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.

Comments

@BigBerny
Copy link

BigBerny commented Sep 15, 2021

This is what the System check widget on the Admin overview shows a warning about UTF8mb4 when I hover (ignore the other warnings, they are all valid):
image

This is what I see in the (full) System Check:
image

  • Matomo Version: 4.4.1
  • PHP Version: 7.4.20
@BigBerny BigBerny added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Sep 15, 2021
@sgiehl
Copy link
Member

sgiehl commented Sep 16, 2021

I guess the problem is, that the overview simply tries to place the results (you can see in the details) into the tooltip, which doesn't work properly in some cases. Maybe we should simply remove the tooltips to avoid irritations.

Kind of related to #17627

@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Sep 16, 2021
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Sep 16, 2021
@tsteur tsteur added this to the Priority Backlog (Help wanted) milestone Sep 16, 2021
@tsteur
Copy link
Member

tsteur commented Sep 16, 2021

Maybe could also think about removing line breaks etc then it might work again (and/or strip html)? It could be quite useful to have these tooltips but if not easily doable we can remove the tooltips 👍

@mwithheld
Copy link
Contributor

To reproduce the problem, run this in mysql as root:

SET GLOBAL local_infile = 'ON';

@mwithheld
Copy link
Contributor

18006

@mwithheld
Copy link
Contributor

mwithheld commented Sep 17, 2021

This kind of fixes Issue #17627 in that it strips tags, leaving the hyperlink text in place, e.g.
<a href="http://blah">Learn more</a> becomes Learn more.

18006-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants