New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mysql row format dynamic option #18002
Conversation
add key not exist
update the database change on the Core Updates
convert naming from disable to enable, add comment, update update, take 3 params.
There is an extra space on create sql, remove the ending space, if there is any. to Pass test.
0837c5c
to
8f5232c
Compare
bf66612
to
8f5232c
Compare
update some description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgiehl I'm not quite sure what we do during the installation. Are we using utf8mb4 by default when possible? Would we need to do anything during the installation so users benefit from this?
update global wording and remove dynamic on in 4.5.0-b1
add createTable dynamic test
@sgiehl be great to let us know if you know maybe whether we need to do anything on installation re this setting |
Yes. We need to use a default that works for all users and change the value on installation. Them same way it's done for utf8mb4 |
add migration row format dynamic
check when installation database is utf8mb4 format then auto enable dynamic row format
@tsteur Updated the Installation script, but not sure about the ms sql option, I set it |
update install mysql schema
update unit test
update dynamic to default when utf8mb4 is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we're getting there. Looks a lot cleaner without the config 👍 sorry for having to remove it but it'll simplify things in the future 🚀
…ation updates remove uft8 function, set row format as a quick function, remove migration updates
@tsteur Sorry about the issue being dragging too long, I should scope it a little bit better at the beginning. |
@peterhashair all good, the problem was we didn't scope the issue well enough in the actual issue. We'll do better :) And good we found that we can simplify it all that's great. |
# Conflicts: # core/Db/Adapter/Pdo/Mssql.php # core/Db/Adapter/Pdo/Pgsql.php
resolve conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a minor comment. Otherwise looks good to me
remove rtrim obsolete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me know
Description:
Add row format equals dynamic as default, regarding the large text field for creating table failure.
Review