Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change bogus user agent that fails on bing.com #17993

Merged
merged 3 commits into from Sep 15, 2021
Merged

change bogus user agent that fails on bing.com #17993

merged 3 commits into from Sep 15, 2021

Conversation

geekdenz
Copy link
Contributor

fixes #17919

Description:

After guessing and trying things it seems like the changed user agent was causing this issue.

Review

@geekdenz
Copy link
Contributor Author

Maybe it should be Chrome and not Safari, I realise.

@geekdenz geekdenz marked this pull request as ready for review September 15, 2021 04:45
justinvelluppillai
justinvelluppillai approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinvelluppillai justinvelluppillai merged commit eecc8b9 into 4.x-dev Sep 15, 2021
@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 16, 2021
@sgiehl sgiehl added this to the 4.5.0 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

SEO Ranking plugin not working - problem with ping? - Fix the random test failures
3 participants
@geekdenz @justinvelluppillai @sgiehl