Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctrine cache to the right version #17992

Merged
merged 1 commit into from Sep 14, 2021
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 13, 2021

Originally component-cache used a fork of doctrine with fixes in the 1.10.2-modified branch (https://github.com/matomo-org/cache/tree/1.10.2-modified).

But recently matomo-org/cache#1 was merged into master instead which is using an older version of doctrine which is missing compatibility with newer PHP versions.

Review

@tsteur tsteur added the Needs Review PRs that need a code review label Sep 13, 2021
@tsteur tsteur added this to the 4.5.0 milestone Sep 13, 2021
@sgiehl sgiehl merged commit 8844eba into 4.x-dev Sep 14, 2021
@sgiehl sgiehl deleted the doctrinecacheupdate branch September 14, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants