Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core:fix-duplicate-log-actions unable to remove duplicates #17990

Open
insekticid opened this issue Sep 13, 2021 · 1 comment
Open

core:fix-duplicate-log-actions unable to remove duplicates #17990

insekticid opened this issue Sep 13, 2021 · 1 comment
Labels
Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users.
Milestone
For Prioritization

Comments

@insekticid
Copy link

insekticid commented Sep 13, 2021 •
edited

I run this command one week ago
./console core:fix-duplicate-log-actions --invalidate-archives >> log.txt

today I checked results and command crashed.

Latest output is:

/var/www/html $ tail -f log.txt 
        Fixed duplicates in log_conversion_item. Time elapsed: 0.001s.
[2223 / 41708] Fixing duplicates for 'http://ad.yieldmanager.com/clk?3,eAGVTcFugzAM.ZreKCIECFO0QzrUiZWgsqaH9BYyChQoFQti5esXCt19lmX7vWc.A4jR-SWVrutn6TlNPS.FADoCQuAiWxoWxhghACGClmWQKXZtv0tI5XXDA5K3QkXJPJJ86nwGe3.qQfDh-PtFH2UYzGJwzMblfib-Wzn7fD4NCVmsVM1.2jHZ.Jm9xwW3KeTj0YkYBadLrijb1vQAyviyqSImIW'
        Fixed duplicates in log_link_visit_action. Time elapsed: 15.819s.
        Fixed duplicates in log_conversion. Time elapsed: 0.002s.
        Fixed duplicates in log_conversion_item. Time elapsed: 0.001s.
[2224 / 41708] Fixing duplicates for 'http://ad.yieldmanager.com/clk?3,eAGVTcFugzAM.ZreKCIEKAj14C1rRQtr02XS2C2krDBKQSwoKl-.tLDeZ1m233t-NsIhXwjEgy.huSLLFl4QIuxw7AdWdgwMKwxDB7k2cgIf2QbcYtv0WwqV16k7hOdCxnQc4QQvAOkI9v6tE9I6.n7SBxGRUSTv-TD5R-K.NWWHv6cRwHTqQ.WbZqBPj2Nk853a1E3WkYpZYicklQlbnZM3VL4ywD'
        Fixed duplicates in log_link_visit_action. Time elapsed: 14.583s.
        Fixed duplicates in log_conversion. Time elapsed: 0.003s.
        Fixed duplicates in log_conversion_item. Time elapsed: 0.001s.
[2225 / 41708] Fixing duplicates for 'http://ad.yieldmanager.com/clk?3,eAGVTcFugzAM.ZreKCIJVFTRDlkpqCqg0mUHcgueN1BBVF26aHz9YNDdZ1l-fu.Jz4RxDxhu3wJCNdN6w945YT4wAlgFleNxzhkhNNzSgPiOmOrY34-FuGxu9peKXW3SYl7Fx4TlTE7hhLu98sPT4g9wiGYzesVhuZ-F.85Snh9PD0IsURR7sEPx.BeWxJdMgs2TzEtlXqsITCbjNnvxgpKe21SCr2'

image

Today I rerun command again and it will start again with total duplicate items: 41708, so no record has been fixed

image

Your Environment

  • Matomo Version: matomo:4.4.1-fpm-alpine
@insekticid insekticid added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Sep 13, 2021
@sgiehl
Copy link
Member

sgiehl commented Nov 11, 2022

@insekticid Sorry to see you didn't get any response one your issue. Seems it somehow slipped through our triaging process.
Do you still have this issue? Looking at the code it looks like the duplicate action are all being deleted at once after all actions have been updated. So if the process stops somewhere in the middle, the next run would beging with the same stuff again...

@sgiehl sgiehl added Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
3 participants
@insekticid @sgiehl @innocraft-automation