Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if not comparing, set show_limit_control to true for Evolution Report #17987

Merged
merged 2 commits into from Sep 15, 2021

Conversation

geekdenz
Copy link
Contributor

fixes #17965

Description:

Assumes we want the report to show_limit_control in all cases but when comparing.

Review

@geekdenz geekdenz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 10, 2021
Co-authored-by: Justin Velluppillai <justin@innocraft.com>
@geekdenz
Copy link
Contributor Author

I don't think these errors are related to my changes:
https://app.travis-ci.com/github/matomo-org/matomo/jobs/536588979#L1061-L1065
but could be wrong. Reviewer, please double check.

@geekdenz geekdenz added the Needs Review PRs that need a code review label Sep 12, 2021
@geekdenz geekdenz marked this pull request as ready for review September 12, 2021 23:12
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here :)

@justinvelluppillai justinvelluppillai merged commit 9585236 into 4.x-dev Sep 15, 2021
@sgiehl
Copy link
Member

sgiehl commented Sep 15, 2021

Reverting this one as it actually makes it impossible to overwrite the property for a report.
The referrer evolution chart that did not show the limit control actually has it disabled in the report. See

$view->config->show_limit_control = false;

So removing this should solve the issue I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Acquisition > Overview report, the Row selector is missing
3 participants