@geekdenz opened this Pull Request on September 10th 2021 Contributor

fixes #17965

Description:

Assumes we want the report to show_limit_control in all cases but when comparing.

Review

@geekdenz commented on September 12th 2021 Contributor

I don't think these errors are related to my changes:
https://app.travis-ci.com/github/matomo-org/matomo/jobs/536588979#L1061-L1065
but could be wrong. Reviewer, please double check.

@sgiehl commented on September 15th 2021 Member

Reverting this one as it actually makes it impossible to overwrite the property for a report.
The referrer evolution chart that did not show the limit control actually has it disabled in the report. See https://github.com/matomo-org/matomo/blob/115527353a9e75e01aa4d263408956ae45403bea/plugins/Referrers/Reports/GetReferrerType.php#L105
So removing this should solve the issue I guess.

This Pull Request was closed on September 15th 2021
Powered by GitHub Issue Mirror