Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically wait for lazy images in UI tests #17981

Merged
merged 1 commit into from Sep 9, 2021
Merged

automatically wait for lazy images in UI tests #17981

merged 1 commit into from Sep 9, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 8, 2021

Description:

follow-up to #17970

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 8, 2021
@sgiehl sgiehl added this to the 4.5.0 milestone Sep 8, 2021
tsteur
tsteur approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sgiehl sgiehl merged commit 03dbff2 into 4.x-dev Sep 9, 2021
@sgiehl sgiehl deleted the lazyimages branch September 9, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur