Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add promotion for seo web vitals, add campaign for Heatmaps and Sessi… #17979

Merged
merged 8 commits into from Sep 13, 2021

Conversation

geekdenz
Copy link
Contributor

@geekdenz geekdenz commented Sep 8, 2021

…on Recording

fixes #17975

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@geekdenz
Copy link
Contributor Author

geekdenz commented Sep 8, 2021

To enable easier review (copied from issue):

Similar to various other premium features we will want to mention this new feature in relevant places similar to eg https://github.com/matomo-org/matomo/blob/4.5.0-b1/plugins/ProfessionalServices/ProfessionalServices.php#L24-L33

As usual we would only show it if the plugin is not installed already.

  • We could show it in the Behaviour -> Performance page maybe?

  • And maybe also in the search engine report?

image

Link to use: https://matomo.org/recommends/seo-web-vitals/
Text: Use SEO Web Vitals to improve your website performance, rank higher in search results and optimise your visitor experience with SEO Web Vitals.

Link: https://matomo.org/recommends/heatmap-session-recording-learn-more/
Wording: Truly understand your visitors by seeing where they click, hover, type and scroll. Replay their actions in a video and ultimately increase conversions

@geekdenz geekdenz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 9, 2021
@geekdenz geekdenz marked this pull request as ready for review September 12, 2021 23:44
@geekdenz geekdenz added the Needs Review PRs that need a code review label Sep 12, 2021
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @geekdenz

Minor tweak: On performance page could we only show it once instead of twice?
image

We would only want to show it after the sparkline report and remove it after the evolution. This way the ad doesn't take too much space away above the fold and we get more important information to show above the fold.

fyi @mattab
we will also show the ad in search engines report see
image

Alternatively, now thinking we could maybe remove it there. We could also show it as part of keywords but it's maybe not as relevant
image

@geekdenz the last part was just an FYI for @mattab . no change needed for the ad in the acquisition report for now. We can always merge and change again later.

@geekdenz
Copy link
Contributor Author

@tsteur sorry missed that it was there twice last week. Of course!

@tsteur
Copy link
Member

tsteur commented Sep 13, 2021

Works 👍 Can you fix the failing UI test https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/48985/PagePerformance_load.png and then merge?

@geekdenz geekdenz merged commit 022c77e into 4.x-dev Sep 13, 2021
@geekdenz geekdenz deleted the m-17975 branch September 13, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote the new SEO web vitals feature
3 participants