Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider and CustomVariables plugin from our core release #17973

Closed
tsteur opened this issue Sep 6, 2021 · 3 comments · Fixed by #18148
Closed

Remove Provider and CustomVariables plugin from our core release #17973

tsteur opened this issue Sep 6, 2021 · 3 comments · Fixed by #18148
Assignees
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Sep 6, 2021

Follow up from matomo-org/matomo-package#112

It's been a while since we released Matomo 4 meaning we can now remove Provider and CustomVariables plugin from the core release and only ship it only through the marketplace.

We no longer want to have in matomo.zip release zip the directories plugins/Providers and plugins/CustomVariables. Of course we also need to test that this won't cause any issues for people that are already on Matomo 4.

@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Sep 6, 2021
@tsteur tsteur added this to the 4.6.0 milestone Sep 6, 2021
@peterhashair peterhashair self-assigned this Oct 6, 2021
@peterhashair peterhashair mentioned this issue Oct 6, 2021
11 tasks
@tsteur tsteur closed this as completed Oct 13, 2021
@tsteur tsteur reopened this Oct 13, 2021
@tsteur
Copy link
Member Author

tsteur commented Oct 13, 2021

Closed this issue too early. @peterhashair there is now a test test_CustomVariablesAndProviderPluginCanBeUninstalledOnceNoLongerIncludedInPackage failing.
image

Seems we possibly also need to adjust the method isPluginBundledWithCore in the plugin manager.

@peterhashair
Copy link
Contributor

@tsteur sorry about that, removed the test.

@mig5
Copy link

mig5 commented Dec 15, 2021

Whoops: on 4.6.2 somehow I hit a fatal error because Provider was still in my config.ini.php as an installed plugin, via this plugin:

user@example:~/piwik/piwik-4.6.2$ grep -r "Provider\Provider" *
plugins/UserCountry/Columns/Country.php:use Piwik\Plugins\Provider\Provider as ProviderProvider;
plugins/UserCountry/Columns/Country.php:        $hostnameExtension = ProviderProvider::getCleanHostname($hostname);

Had to remove 'Provider' from the installed plugins by hand from the config.ini.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
3 participants