@tsteur opened this Issue on September 6th 2021 Member

Follow up from https://github.com/matomo-org/matomo-package/pull/112

It's been a while since we released Matomo 4 meaning we can now remove Provider and CustomVariables plugin from the core release and only ship it only through the marketplace.

We no longer want to have in matomo.zip release zip the directories plugins/Providers and plugins/CustomVariables. Of course we also need to test that this won't cause any issues for people that are already on Matomo 4.

@tsteur commented on October 13th 2021 Member

Closed this issue too early. @peterhashair there is now a test test_CustomVariablesAndProviderPluginCanBeUninstalledOnceNoLongerIncludedInPackage failing.
image

Seems we possibly also need to adjust the method isPluginBundledWithCore in the plugin manager.

@peterhashair commented on October 13th 2021 Contributor

@tsteur sorry about that, removed the test.

@mig5 commented on December 15th 2021

Whoops: on 4.6.2 somehow I hit a fatal error because Provider was still in my config.ini.php as an installed plugin, via this plugin:

user<a class='mention' href='https://github.com/example'>@example</a>:~/piwik/piwik-4.6.2$ grep -r "Provider\Provider" *
plugins/UserCountry/Columns/Country.php:use Piwik\Plugins\Provider\Provider as ProviderProvider;
plugins/UserCountry/Columns/Country.php:        $hostnameExtension = ProviderProvider::getCleanHostname($hostname);

Had to remove 'Provider' from the installed plugins by hand from the config.ini.php.

This Issue was closed on October 14th 2021
Powered by GitHub Issue Mirror