New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing UI tests #17970
Fix failing UI tests #17970
Conversation
Note: I've introduced a new method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to call this automatically as part of
this.waitForNetworkIdle()
this.webpage.on('load', () => {
(I know those ones are only loaded later but if it might still be good just in case we use it more in the future)- maybe also in
this.webpage.on('requestfinished'
Then developers maybe won't need to think about this as it can be tricky to find out etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one.
@tsteur will check if that works and create a new PR if so |
Description:
Due to various code changes (like #17937, #17879) UI tests are currently failing. This PR aims to fix them again.
Review