@sgiehl opened this Pull Request on September 6th 2021 Member

Description:

Due to various code changes (like #17937, #17879) UI tests are currently failing. This PR aims to fix them again.

Review

@sgiehl commented on September 7th 2021 Member

Note: I've introduced a new method page.waitForLazyImages(), which removes the loading attribute from all images and then waits for all images to load. Otherwise we can't ensure in some UI tests which images would be loaded or not.

@justinvelluppillai commented on September 8th 2021 Contributor

@sgiehl sorry maybe jumped the gun merging there didn't notice @tsteur 's suggestion. Can create a new PR if we want to implement those suggestions also.

@sgiehl commented on September 8th 2021 Member

@tsteur will check if that works and create a new PR if so

This Pull Request was closed on September 8th 2021
Powered by GitHub Issue Mirror