Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notice Undefined index in DataCollection #17967

Merged
merged 2 commits into from Sep 6, 2021
Merged

Fix notice Undefined index in DataCollection #17967

merged 2 commits into from Sep 6, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 6, 2021 •
edited

Description:

fix #17966

This used to be skipped in https://github.com/matomo-org/matomo/blob/4.4.1/core/Archive/DataCollection.php#L193-L203

Review

@tsteur tsteur marked this pull request as draft September 6, 2021 03:32
@tsteur tsteur marked this pull request as ready for review September 6, 2021 03:44
@tsteur tsteur added the Needs Review PRs that need a code review label Sep 6, 2021
@tsteur tsteur added this to the 4.5.0 milestone Sep 6, 2021
sgiehl
sgiehl approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsteur should we create an issue to investigate that?

@tsteur
Copy link
Member Author

tsteur commented Sep 6, 2021

not needed @sgiehl

@tsteur tsteur merged commit 420733d into 4.x-dev Sep 6, 2021
@tsteur tsteur deleted the m17966 branch September 6, 2021 21:31
sgiehl pushed a commit that referenced this pull request Sep 7, 2021
@tsteur @sgiehl
Fix notice Undefined index in DataCollection (#17967)
20c3fec
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Warning DataCollection.php(381): Notice - Undefined index: 2021-04-26,2021-05-02
3 participants
@tsteur @sgiehl @justinvelluppillai