Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecureHash is not secure #17960

Closed
wants to merge 7 commits into from
Closed

SecureHash is not secure #17960

wants to merge 7 commits into from

Conversation

mwithheld
Copy link
Contributor

Description:

Fix issue #15278 Secure Hash is not secure. Use passwordHelper->hash() which uses the Password::preferredAlgorithm() hash.

justinvelluppillai
justinvelluppillai suggested changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've included your other PR in this one also, maybe you could create a new one off the 4.x-dev branch and cherry-pick the relevant commit only?

@mwithheld mwithheld closed this Sep 3, 2021
@mwithheld mwithheld deleted the issue/15278 branch September 3, 2021 03:37
@mwithheld
Copy link
Contributor Author

Moved into PR #17961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwithheld @justinvelluppillai