Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more img sources when embedding page in an iframe #17958

Merged
merged 1 commit into from Sep 3, 2021
Merged

Allow more img sources when embedding page in an iframe #17958

merged 1 commit into from Sep 3, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2021

Noticed this while testing changes in the heatmaps plugin. Was otherwise getting this error:

image

It's needed because we now set img-src in the beginning:

image

Review

@tsteur
Allow more img sources when embedding page in an iframe
be7551d 
Noticed this while testing changes in the heatmaps plugin.
@tsteur tsteur added the Needs Review PRs that need a code review label Sep 3, 2021
@tsteur tsteur added this to the 4.5.0 milestone Sep 3, 2021
justinvelluppillai
justinvelluppillai approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course.

@justinvelluppillai justinvelluppillai merged commit ce976b3 into 4.x-dev Sep 3, 2021
@justinvelluppillai justinvelluppillai deleted the pageframe branch September 3, 2021 02:08
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @justinvelluppillai