Add CLI config:get and config:delete #17956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Sep 7, 2021
There was a problem hiding this comment.
@mwithheld Thanks for creating this pull request. I did a review and left a couple of comments. Would be nice if you have some time to apply that
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
# Conflicts: # plugins/CoreAdminHome/Commands/ConfigDelete.php # plugins/CoreAdminHome/Commands/ConfigGet.php
…gShouldYieldEmpty
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
…eTest.php to plugins/CoreAdminHome/tests/Integration/Commands/ConfigDeleteTest.php
…st.php to plugins/CoreAdminHome/tests/Integration/Commands/ConfigGetTest.php
…st.php to plugins/CoreAdminHome/tests/Integration/Commands/SetConfigTest.php
sgiehl
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Thanks again @mwithheld for applying the changes. I've added some last fixes and now it should be good to merge 🎉
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue #16576 Add logic to CLI for config:delete and config:get
Review