Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When processing a dependent archive for a range, then only process the requested plugin, not all plugins #17943

Merged
merged 2 commits into from Sep 2, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 31, 2021

Description:

Say you are viewing the goals overview page for a range period. What happens is

Generally, for ranges when triggered from the browser (not archive), we always only want to archive the specific plugin.

Review

@tsteur tsteur added this to the 4.5.0 milestone Aug 31, 2021
@tsteur tsteur added the Needs Review PRs that need a code review label Aug 31, 2021
@tsteur
Copy link
Member Author

tsteur commented Aug 31, 2021

Debugged and profiled this and now no longer aggregates multiple archives for all plugins. Only the requested ones. Hoping there are no side effects.

I would add a test but don't have the time plus the outcome stays the same anyway.

@tsteur tsteur merged commit 27d0af9 into 4.x-dev Sep 2, 2021
@tsteur tsteur deleted the pluginrangeall branch September 2, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant