When processing a dependent archive for a range, then only process the requested plugin, not all plugins #17943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Say you are viewing the goals overview page for a range period. What happens is
processDependentArchive
with a segment in https://github.com/matomo-org/matomo/blob/4.5.0-b1/plugins/Goals/Archiver.php#L505visitorType==returning
then it would suddenly process all archives becauseisSegmentPreProcessed($segment)===true
. Or when requesting a segment that is being pre-processed.Generally, for ranges when triggered from the browser (not archive), we always only want to archive the specific plugin.
Review